etseidl commented on code in PR #6987:
URL: https://github.com/apache/arrow-rs/pull/6987#discussion_r1918886625
##########
parquet/src/arrow/array_reader/primitive_array.rs:
##########
@@ -270,6 +270,59 @@ where
Arc::new(array) as ArrayRef
}
+ ArrowType::Dictionary(_, value_type) => match value_type.as_ref() {
Review Comment:
This looks correct to me. It would be nice if we could get some code reuse
here.
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -2670,6 +2712,52 @@ mod tests {
one_column_roundtrip_with_schema(Arc::new(d), schema);
}
+ #[test]
+ fn arrow_writer_decimal128_dictionary() {
Review Comment:
Verified that tests fail if the read changes are reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
