kou commented on code in PR #45274:
URL: https://github.com/apache/arrow/pull/45274#discussion_r1919472312
##########
matlab/src/matlab/+arrow/+io/+ipc/RecordBatchStreamReader.m:
##########
@@ -26,14 +26,34 @@
Schema
end
- methods
- function obj = RecordBatchStreamReader(filename)
Review Comment:
Thanks for detailed explanation for this API design. My idea isn't a strong
opinion. So this design is OK to me.
FYI: If MATLAB has a keyword argument feature, we can consider another API
design with it. e.g. `RecordBatchStreamReader(filename: path)` and
`RecordBatchStreamReader(bytes: data)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
