kevingurney commented on code in PR #45274:
URL: https://github.com/apache/arrow/pull/45274#discussion_r1920805520
##########
matlab/src/matlab/+arrow/+io/+ipc/RecordBatchStreamReader.m:
##########
@@ -26,14 +26,34 @@
Schema
end
- methods
- function obj = RecordBatchStreamReader(filename)
Review Comment:
Thanks for the review, @kou!
> FYI: If MATLAB has a keyword argument feature, we can consider another API
design
This is a very interesting point. MATLAB does in fact support name-value
pairs - which *can* be used in this way.
However, there is limited design precedent for functions included with
MATLAB which:
1. Have zero required positional arguments *AND*
2. Support name-value pairs that are all mutually exclusive of one another
(i.e. you shouldn't use `Filename` and `Bytes` together)
There are a few instances of this in MATLAB, but typically, MATLAB functions
use name-value pairs for optional arguments in conjunction with required
positional arguments.
Despite the limited design precedent, this is still an interesting point,
and this is certainly something we can think more about and potentially explore
in the future.
For the time being, it sounds like having two separate "construction"
functions is fairly reasonable, so I think we can proceed with that design.
Thanks again for your thoughtful feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
