Jefffrey commented on code in PR #6994:
URL: https://github.com/apache/arrow-rs/pull/6994#discussion_r1922211007
##########
arrow-schema/src/datatype.rs:
##########
@@ -196,6 +196,13 @@ pub enum DataType {
/// DataType::Timestamp(TimeUnit::Second, Some("literal".into()));
/// DataType::Timestamp(TimeUnit::Second,
Some("string".to_string().into()));
/// ```
+ /// For UTC time
+ /// ----------------------------
+ /// For UTC time, it is possible to use either the timezone
representation, such as "UTC", or the absolute time zone offset "+00:00".
+ /// However, it is better to use the offset representation, as it is more
explicit and less ambiguous.
+ /// This also ensures that other arrow-rs functionalities can interpret
the UTC timestamps correctly
+ /// For example, the `with_timezone_utc` method that is applied on
timestamp arrays to add the UTC timezone.
Review Comment:
If I'm understanding the original issue correctly, this isn't limited to UTC
and +00:00, right? If we substitute JST and +09:00 we'd run into the same
issue; in this case, it might be worth generalizing this documentation such
that it isn't specific to UTC but more around offsets vs named timezones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
