Jefffrey commented on code in PR #6994:
URL: https://github.com/apache/arrow-rs/pull/6994#discussion_r1922262786
##########
arrow-schema/src/datatype.rs:
##########
@@ -196,6 +196,13 @@ pub enum DataType {
/// DataType::Timestamp(TimeUnit::Second, Some("literal".into()));
/// DataType::Timestamp(TimeUnit::Second,
Some("string".to_string().into()));
/// ```
+ /// For UTC time
+ /// ----------------------------
+ /// For UTC time, it is possible to use either the timezone
representation, such as "UTC", or the absolute time zone offset "+00:00".
+ /// However, it is better to use the offset representation, as it is more
explicit and less ambiguous.
+ /// This also ensures that other arrow-rs functionalities can interpret
the UTC timestamps correctly
+ /// For example, the `with_timezone_utc` method that is applied on
timestamp arrays to add the UTC timezone.
Review Comment:
True, but some timezones have fixed offsets where DST doesn't factor in
(hence why I gave example of JST). Just thought it might be beneficial to make
it clear that even if the named timezone has only 1 fixed offset ever, they
still aren't equivalent in the eyes of arrow-rs (and can still highlight UTC as
the main example for this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
