alamb commented on a change in pull request #9770: URL: https://github.com/apache/arrow/pull/9770#discussion_r599589540
########## File path: rust/parquet/README.md ########## @@ -50,14 +50,18 @@ See [crate documentation](https://docs.rs/crate/parquet/4.0.0-SNAPSHOT) on avail If you are upgrading from version 3.0 or previous of this crate, you likely need to change your code to use [`ConvertedType`] rather than -[`LogicalType`]. Version 4.0 introduces an *entirely new* struct -called `LogicalType` to align with the `LogicalType` introduced in -Parquet Format 2.4.0. The type previously called `LogicalType` was was -renamed to `ConvertedType`. +[`LogicalType`] to preserve existing behaviour in your code. +Version 2.4.0 of the Parquet format introduced a `LogicalType` to replace the existing `ConvertedType`. +This crate used `parquet::basic::LogicalType` to map to the `ConvertedType`, but this has been renamed to `parquet::basic::ConvertedType` from version 4.0 of this crate. + +The `ConvertedType` is deprecated in the format, but is still written +to preserve backward compatibility. +It is preferred that `LogicalType` is used, as it suports nanosecond Review comment: ```suggestion It is preferred that `LogicalType` is used, as it supports nanosecond ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org