xborder commented on issue #1906: URL: https://github.com/apache/arrow-adbc/issues/1906#issuecomment-2610511283
I was digging trying to understand the difference between `xdbc_data_type` and `xdbc_sql_data_type` as I'm currently doing some changes to the FlightSQL driver to be used in a application so I'd like to clarify this. My understanding of this thread and [this](https://lists.apache.org/thread/volwt9wvq9qz607tdw4131c4fplg59rv) thread is: * `xdbc_data_type` should be a value matching a XdbcDataType as it is defined [here](https://github.com/apache/arrow-adbc/blob/37aff51599dbb62c4a810f392476da1d85ff8f37/go/adbc/driver/internal/shared_utils.go#L510). This is what gets exposed to applications consuming the driver and is mostly inspired by JDBC/ODBC types * `xdbc_sql_data_type` reflects a source specific type. Imagining that there's a database that has the CURRENCY type and internally it has the value 1234, `xdbc_sql_data_type` should be 1234. As I see it, this is mostly contextual information for the application using the driver As for the questions: 1. Is something wrong with how I understood this? 2. Should applications rely solely on `xbdc_sql_data_type`? I'm for-seeing a risk here where applications assume it should match XdbcDataType enum and that should not be the case. 3. FligtSQL [documentation](https://github.com/apache/arrow/blob/dc581f09f8670ee44e15a801742d574ac93541d1/format/FlightSql.proto#L1083) is saying that `data_type` is `The SQL data type`, `sql_data_type` is `...values can be seen in the XdbcDataType enum` and that they're both the same thing. Based on what was said here, is it fair to assume FlightSQL documentation is incorrect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
