singh1203 commented on code in PR #250: URL: https://github.com/apache/arrow-go/pull/250#discussion_r1938246295
########## .github/workflows/benchmark.yml: ########## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Benchmarks +on: + push: + branches: [main] + pull_request: + branches: [main] + paths: + - ".github/workflows/benchmark.yml" + workflow_dispatch: +permissions: + contents: read +jobs: + benchmark: + runs-on: ubuntu-latest + container: debian:12 + strategy: + matrix: + go: ['1.22.7'] + arch: ['amd64'] + steps: + - uses: actions/checkout@v4 + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: '3.9' + - name: Install dependencies + run: | + apt-get update + apt-get install -y build-essential git python3-pip + - name: Install Go ${{ matrix.go }} for Benchmarks + uses: actions/setup-go@v5 + with: + go-version: ${{ matrix.go }} + cache: true + cache-dependency-path: go.sum + - name: Run Benchmarks + if: >- + success() && github.event_name == 'push' && github.repository == 'apache/arrow-go' && github.ref_name == 'main' + env: + CONBENCH_URL: https://conbench.ursa.dev + CONBENCH_EMAIL: ${{ secrets.CONBENCH_EMAIL }} + CONBENCH_PASSWORD: ${{ secrets.CONBENCH_PASS }} + CONBENCH_REF: ${{ github.ref_name }} + CONBENCH_MACHINE_INFO_NAME: ${{ matrix.arch }}-debian-12 + run: | + python3 -m pip install benchadapt@git+https://github.com/conbench/conbench.git@main#subdirectory=benchadapt/python + python3 ci/scripts/go_bench_adapt.py Review Comment: Well, I went with: ``` - name: Run benchmarks run: | ci/scripts/bench.sh --json - name: Upload results if: github.event_name == 'push' && github.repository == 'apache/arrow-go' && github.ref_name == 'main' env: ... run: | ... ``` Since it makes more sense to trigger a push event on the main branch and the previous review from @assignUser [here](https://github.com/apache/arrow-go/pull/250#discussion_r1917066372) suggests that benchmark dumps are quite large and no pull request based triggering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
