Copilot commented on code in PR #7062:
URL: https://github.com/apache/arrow-rs/pull/7062#discussion_r1938327378
##########
arrow-ord/src/sort.rs:
##########
@@ -833,14 +843,16 @@ mod tests {
assert_eq!(output, expected)
}
- fn test_sort_decimal128_array(
- data: Vec<Option<i128>>,
+ fn test_sort_decimal_array<T: DecimalType>(
+ data: Vec<Option<usize>>,
options: Option<SortOptions>,
limit: Option<usize>,
- expected_data: Vec<Option<i128>>,
+ expected_data: Vec<Option<usize>>,
Review Comment:
The parameter 'data' should be of type 'Vec<Option<i128>>' to be consistent
with the original function 'create_decimal128_array'.
```suggestion
data: Vec<Option<i128>>,
options: Option<SortOptions>,
limit: Option<usize>,
expected_data: Vec<Option<i128>>,
```
##########
arrow-ord/src/sort.rs:
##########
@@ -795,10 +795,18 @@ mod tests {
use rand::seq::SliceRandom;
use rand::{Rng, RngCore, SeedableRng};
- fn create_decimal128_array(data: Vec<Option<i128>>) -> Decimal128Array {
+ fn create_decimal_array<T: DecimalType>(
+ data: Vec<Option<usize>>,
Review Comment:
The parameter 'data' should be of type 'Vec<Option<i128>>' to be consistent
with the original function 'create_decimal128_array'.
```suggestion
data: Vec<Option<i128>>,
```
##########
arrow-ord/src/sort.rs:
##########
@@ -809,13 +817,15 @@ mod tests {
.unwrap()
}
- fn test_sort_to_indices_decimal128_array(
- data: Vec<Option<i128>>,
+ fn test_sort_to_indices_decimal_array<T: DecimalType>(
+ data: Vec<Option<usize>>,
Review Comment:
The parameter 'data' should be of type 'Vec<Option<i128>>' to be consistent
with the original function 'create_decimal128_array'.
```suggestion
data: Vec<Option<i128>>,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
