CurtHagenlocher commented on code in PR #7062:
URL: https://github.com/apache/arrow-rs/pull/7062#discussion_r1938327932
##########
arrow-ord/src/sort.rs:
##########
@@ -795,10 +795,18 @@ mod tests {
use rand::seq::SliceRandom;
use rand::{Rng, RngCore, SeedableRng};
- fn create_decimal128_array(data: Vec<Option<i128>>) -> Decimal128Array {
+ fn create_decimal_array<T: DecimalType>(
+ data: Vec<Option<usize>>,
Review Comment:
I was just curious to see what kind of feedback Copilot would produce.
The reason these are `usize` and not `i128` is because there are conversions
from `usize` that will make this code work for `Decimal32Array` and
`Decimal64Array` in a future change, and the same conversions don't exist for
`i128`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
