nealrichardson commented on a change in pull request #9798:
URL: https://github.com/apache/arrow/pull/9798#discussion_r600907730



##########
File path: r/R/dplyr.R
##########
@@ -216,6 +215,52 @@ column_select <- function(.data, ..., .FUN = vars_select) {
   .data
 }
 
+relocate.arrow_dplyr_query <- function(.data, ..., .before = NULL, .after = 
NULL) {
+  .data <- arrow_dplyr_query(.data)
+
+  # TODO: look for unsupported tidyselect selection helpers in exprs(...),
+  # .before, and .after and throw an error if detected

Review comment:
       Yeah, those won't work. Error should be expected, preferably with a 
useful message. Followup JIRA sounds right, it's a bigger issue and not 
confined to relocate()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to