pitrou commented on code in PR #45515:
URL: https://github.com/apache/arrow/pull/45515#discussion_r1952936436
##########
cpp/src/arrow/compute/key_map_internal_avx2.cc:
##########
@@ -385,33 +382,52 @@ int SwissTable::extract_group_ids_avx2(const int
num_keys, const uint32_t* hashe
_mm256_storeu_si256(reinterpret_cast<__m256i*>(out_group_ids) + i,
group_id);
}
} else {
+ int num_groupid_bits = num_groupid_bits_from_log_blocks(log_blocks_);
+ int num_groupid_bytes = num_groupid_bits / 8;
+ uint32_t mask = num_groupid_bytes == 1 ? 0xFF
+ : num_groupid_bytes == 2 ? 0xFFFF
+ : 0xFFFFFFFF;
Review Comment:
Is there a reason for expanding the possible values instead of simply using
the usual bitshift formula?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
