jecsand838 commented on PR #6965: URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2661149042
@tustvold @alamb I have removed all changes and functionality not related to Avro reader type support and `.avro` file tests. Based on the plan outlined above, this should strictly align with the requirements for PR 1. > To make a specific proposal for splitting up this PRs' functionality as suggested by @tustvold -- https://github.com/apache/arrow-rs/pull/6965#issuecomment-2585189456, one way to do so would be: > > First PR: Reader improvements / tests showing reading existing .avro files > Second PR: Minimal Writer support (with tests showing round tripping for a few basic data types) > Subsequent PRs: Additional PRs to support writing additional data types > The rationale for breaking it up this way would be to have better confidence in the read path to ensure round tripping also works as needed The code remaining in this PR successfully reads all `.avro` test files in the repository, including the Impala files. If this approach is acceptable, I can create a follow-up PR for the Avro `Reader`, `ReaderBuilder`, etc., once this is merged. If I further split the changes, the `.avro` file tests will no longer all pass. If that level of granularity is required, could you provide guidance on how to break down the PRs by `.avro` file? CC: @svencowart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
