kawadakk opened a new pull request, #7144:
URL: https://github.com/apache/arrow-rs/pull/7144
# Which issue does this PR close?
Closes #6302.
# Rationale for this change
Fixing a bug.
# What changes are included in this PR?
[`arrow_select::dictionary::merge_dictionary_values`](https://github.com/apache/arrow-rs/blob/38d6e691f4ee1b356f28d77b6820de67166c51c3/arrow-select/src/dictionary.rs#L143)
now preserves null values from input dictionaries. This is necessary because
keys can reference null values. Without this change, the entries of
`MergedDictionaries::key_mappings` corresponding to null values would be left
unset, causing
[`concat`](https://github.com/apache/arrow-rs/blob/38d6e691f4ee1b356f28d77b6820de67166c51c3/arrow-select/src/concat.rs#L109)
and
[`interleave`](https://github.com/apache/arrow-rs/blob/38d6e691f4ee1b356f28d77b6820de67166c51c3/arrow-select/src/interleave.rs#L229)
to remap all elements referencing them to whatever value at index 0, producing
an erroneous result.
The handling of null keys (physical nulls) is unchanged.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
