lidavidm commented on code in PR #288: URL: https://github.com/apache/arrow-go/pull/288#discussion_r1958840456
########## internal/utils/min_max_avx2_amd64.s: ########## @@ -488,7 +488,7 @@ LBB3_5: DATA LCDATA3<>+0x000(SB)/8, $0x7fffffff80000000 GLOBL LCDATA3<>(SB), 8, $8 -TEXT ·_int32_max_min_avx2(SB), $0-32 +TEXT ·_int32_max_min_avx2(SB), NOSPLIT, $8-32 Review Comment: Is the NOSPLIT only needed here and not in the other locations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
