kou commented on code in PR #288:
URL: https://github.com/apache/arrow-go/pull/288#discussion_r1958881743
##########
internal/utils/min_max_avx2_amd64.s:
##########
@@ -133,7 +133,7 @@ LBB0_5:
JNE LBB0_9
JMP LBB0_10
-TEXT ·_uint8_max_min_avx2(SB), $0-32
+TEXT ·_uint8_max_min_avx2(SB), NOSPLIT, $0-32
Review Comment:
I'm not familiar with assembly but is `$0` OK here? Should we use `$8` like
others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
