kou commented on code in PR #45442: URL: https://github.com/apache/arrow/pull/45442#discussion_r1966984598
########## ci/docker/python-wheel-windows-test-vs2022-base.dockerfile: ########## @@ -0,0 +1,67 @@ +# escape=` + +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# NOTE: You must update PYTHON_WHEEL_WINDOWS_TEST_IMAGE_REVISION in .env +# when you update this file. + +FROM mcr.microsoft.com/windows/servercore:ltsc2022 + +# Ensure we in a command shell and not Powershell +SHELL ["cmd", "/S", "/C"] + +# Install MSVC BuildTools +# +# The set of components below (lines starting with --add) is the most minimal +# set we could find that would still compile Arrow C++. +RUN ` + curl -SL --output vs_buildtools.exe https://aka.ms/vs/17/release/vs_buildtools.exe ` + && (start /w vs_buildtools.exe --quiet --wait --norestart --nocache ` + --installPath "%ProgramFiles(x86)%\Microsoft Visual Studio\2022\BuildTools" ` + --add Microsoft.VisualStudio.Component.VC.CoreBuildTools ` + --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 ` + --add Microsoft.VisualStudio.Component.Windows10SDK.20348 ` + --add Microsoft.VisualStudio.Component.VC.CMake.Project ` + || IF "%ERRORLEVEL%"=="3010" EXIT 0) ` + && del /q vs_buildtools.exe + +# Install choco CLI +# +# We switch into Powershell just for this command and switch back to cmd +# See https://chocolatey.org/install#completely-offline-install +SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] +RUN ` + Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1')) +SHELL ["cmd", "/S", "/C"] + +# Install git, wget, minio +RUN choco install --no-progress -r -y git wget +RUN curl https://dl.min.io/server/minio/release/windows-amd64/archive/minio.RELEASE.2024-09-13T20-26-02Z ` + --output "C:\Windows\Minio.exe" + +# Install archiver to extract xz archives (for timezone database). Review Comment: We use a package in PyPI for timezone database now. Can we remove using archiver? ########## .env: ########## @@ -95,8 +95,8 @@ VCPKG="f7423ee180c4b7f40d43402c2feb3859161ef625" # 2024.06.15 Release # ci/docker/python-*-windows-*.dockerfile or the vcpkg config. # This is a workaround for our CI problem that "archery docker build" doesn't # use pulled built images in dev/tasks/python-wheels/github.windows.yml. -PYTHON_WHEEL_WINDOWS_IMAGE_REVISION=2025-02-03 -PYTHON_WHEEL_WINDOWS_TEST_IMAGE_REVISION=2025-01-27 +PYTHON_WHEEL_WINDOWS_IMAGE_REVISION=ltsc2022-KB5049983 +PYTHON_WHEEL_WINDOWS_TEST_IMAGE_REVISION=ltsc2022-KB5049983 Review Comment: Can we keep using date based revision? We may need to bump this revision even when we use the same base image. For example, we need to bump this revision when we change only our Dockerfile such as adding one more `RUN ...`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
