birschick-bq commented on code in PR #2540:
URL: https://github.com/apache/arrow-adbc/pull/2540#discussion_r1974069716
##########
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:
##########
@@ -349,7 +350,7 @@ protected override SqlCharVarcharParserResult
GenerateResult(string input, Match
int precision = int.TryParse(precisionGroup.Value, out int
candidatePrecision)
? candidatePrecision
- : throw new ArgumentException($"Unable to parse length:
'{precisionGroup.Value}'", nameof(input));
+ : -1; // precision not found
Review Comment:
Resolved. Now uses a default value, as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
