zanmato1984 commented on code in PR #45421:
URL: https://github.com/apache/arrow/pull/45421#discussion_r1979278789
##########
cpp/src/arrow/acero/concurrent_queue_internal.h:
##########
@@ -35,7 +36,12 @@ class ConcurrentQueue {
//
T Pop() {
Review Comment:
Oh, I mean remove it from both `ConcurrentQueue` and
`BackpressureConcurrentQueue` so there isn't compatibility issue between them.
And especially now, before making them public, is the last timing that we
are free to make such changes. After they are made public, it's much harder to
remove them than adding them back (if necessary).
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
