zanmato1984 commented on code in PR #45421:
URL: https://github.com/apache/arrow/pull/45421#discussion_r1979736056
##########
cpp/src/arrow/acero/concurrent_queue_internal.h:
##########
@@ -35,7 +36,12 @@ class ConcurrentQueue {
//
T Pop() {
Review Comment:
Well, my suggestion of removing `Pop` is solely because it is not called
anywhere (or in other words, replaced by `WaitAndPop`), not that it is
"unsafe". And this reason doesn't apply to `Front`, so I wouldn't suggest
removing it considering it is being widely used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
