davidhcoe commented on code in PR #2587:
URL: https://github.com/apache/arrow-adbc/pull/2587#discussion_r1985543757
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -208,7 +226,7 @@ private IArrowType GetType(TableFieldSchema field,
IArrowType type)
return type;
}
- static IArrowReader ReadChunk(BigQueryReadClient readClient, string
streamName)
+ static IArrowReader? ReadChunk(BigQueryReadClient readClient, string
streamName)
Review Comment:
This changes the internal contract slightly because ReadChunk can now result
in a null if the stream doesn't have any rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
