davidhcoe commented on code in PR #2587:
URL: https://github.com/apache/arrow-adbc/pull/2587#discussion_r1985545144
##########
csharp/src/Drivers/BigQuery/BigQueryStatement.cs:
##########
@@ -112,7 +112,13 @@ public override QueryResult ExecuteQuery()
ReadSession rrs = readClient.CreateReadSession("projects/" +
results.TableReference.ProjectId, rs, maxStreamCount);
long totalRows = results.TotalRows == null ? -1L :
(long)results.TotalRows.Value;
- IArrowArrayStream stream = new
MultiArrowReader(TranslateSchema(results.Schema), rrs.Streams.Select(s =>
ReadChunk(readClient, s.Name)));
+
+ var readers = rrs.Streams
Review Comment:
To make up for the internal contract change of allowing null on ReadChunk,
only pass valid readers (that aren't null) to the MultiArrowReader. If it is
empty, then no errors occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
