davidhcoe commented on code in PR #2587:
URL: https://github.com/apache/arrow-adbc/pull/2587#discussion_r1986217699
##########
csharp/test/Apache.Arrow.Adbc.Tests/ClientTests.cs:
##########
@@ -268,7 +277,25 @@ static void AssertTypeAndValue(
}
else
{
- Assert.True(ctv.ExpectedValue.Equals(value),
Utils.FormatMessage($"Expected value [{ctv.ExpectedValue}] does not match
actual value [{value}] for {ctv.Name} for query [{query}]", environmentName));
+ bool areEqual = false;
+
+ if (value is ExpandoObject)
Review Comment:
No. There is a check above `if
(type.BaseType?.Name.Contains("PrimitiveArray") == false)` that puts us in a
different path for comparing arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
