zhuqi-lucas commented on PR #7263: URL: https://github.com/apache/arrow-rs/pull/7263#issuecomment-2717354157
> Thank you very much @zhuqi-lucas! > > I think this PR just needs > > 1. some adjustment on data allocation > 2. A performance benchmark. Perhaps you could extend this one: > > https://github.com/apache/arrow-rs/blob/a75da00eed762f8ab201c6cb4388921ad9b67e7e/arrow/benches/json_reader.rs#L45-L44 Thank you @alamb for review, addressed the comments now. And also the benchmark result for utf8view seems better: ```rust small_bench_primitive time: [6.2293 µs 6.2540 µs 6.2810 µs] change: [+0.6034% +1.1278% +1.6922%] (p = 0.00 < 0.05) Change within noise threshold. Found 11 outliers among 100 measurements (11.00%) 1 (1.00%) low mild 7 (7.00%) high mild 3 (3.00%) high severe ``` ```rust small_bench_primitive_with_utf8view time: [6.0220 µs 6.0420 µs 6.0649 µs] Found 3 outliers among 100 measurements (3.00%) 1 (1.00%) low mild 2 (2.00%) high mild ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
