paleolimbot commented on code in PR #2609:
URL: https://github.com/apache/arrow-adbc/pull/2609#discussion_r1991826375
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -642,13 +663,14 @@ def _bind(self, parameters) -> None:
self._stmt.bind(parameters)
elif hasattr(parameters, "__arrow_c_stream__"):
self._stmt.bind_stream(parameters)
- elif isinstance(parameters, pyarrow.RecordBatch):
+ # TODO: PyCapsule
Review Comment:
`nanoarrow.c_array_stream()` has this path if you'd like to copy it/copy the
tests:
https://github.com/apache/arrow-nanoarrow/blob/63fca8bafafbe574929e2fe662f82dcd60fde0d0/python/src/nanoarrow/c_array_stream.py#L24-L97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]