zeroshade commented on code in PR #2609:
URL: https://github.com/apache/arrow-adbc/pull/2609#discussion_r1995742751
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -40,25 +49,22 @@
try:
import pyarrow
-except ImportError as e:
- raise ImportError("PyArrow is required for the DBAPI-compatible
interface") from e
-
-try:
import pyarrow.dataset
except ImportError:
- _pya_dataset = ()
- _pya_scanner = ()
+ _has_pyarrow = False
else:
- _pya_dataset = (pyarrow.dataset.Dataset,)
- _pya_scanner = (pyarrow.dataset.Scanner,)
+ _has_pyarrow = True
+ from . import _reader
import adbc_driver_manager
-from . import _lib, _reader
+from . import _lib
from ._lib import _blocking_call
if typing.TYPE_CHECKING:
import pandas
+ import polars
+ import pyarrow
Review Comment:
don't we need another try/except here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
