zanmato1984 commented on code in PR #45701:
URL: https://github.com/apache/arrow/pull/45701#discussion_r1995152475
##########
cpp/src/arrow/compute/expression_test.cc:
##########
@@ -338,6 +338,13 @@ TEST(Expression, Equality) {
literal(std::numeric_limits<double>::signaling_NaN()));
}
+ Expression expr1;
Review Comment:
```suggestion
// Equality when underlying `impl_` is null.
Expression expr1;
```
##########
cpp/src/arrow/compute/expression_test.cc:
##########
@@ -338,6 +338,13 @@ TEST(Expression, Equality) {
literal(std::numeric_limits<double>::signaling_NaN()));
}
+ Expression expr1;
+ Expression expr2(literal(1));
+ EXPECT_NE(literal("a"), expr1);
Review Comment:
```suggestion
EXPECT_NE(literal("a"), expr1);
EXPECT_NE(expr1, literal("a"));
```
##########
cpp/src/arrow/compute/expression_test.cc:
##########
@@ -338,6 +338,13 @@ TEST(Expression, Equality) {
literal(std::numeric_limits<double>::signaling_NaN()));
}
+ Expression expr1;
+ Expression expr2(literal(1));
+ EXPECT_NE(literal("a"), expr1);
Review Comment:
Still mutual inequality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
