raulcd commented on code in PR #45766:
URL: https://github.com/apache/arrow/pull/45766#discussion_r1995166120
##########
python/pyarrow/__init__.py:
##########
@@ -412,14 +412,24 @@ def append_library_dir(library_dir):
append_library_dir(library_dir[2:])
if _sys.platform == 'win32':
+ python_base_install = _os.path.dirname(_sys.executable)
+
# TODO(wesm): Is this necessary, or does setuptools within a conda
# installation add Library\lib to the linker path for MSVC?
- python_base_install = _os.path.dirname(_sys.executable)
library_dir = _os.path.join(python_base_install, 'Library', 'lib')
if _os.path.exists(_os.path.join(library_dir, 'arrow.lib')):
append_library_dir(library_dir)
+ # GH-45530: Add pyarrow.libs dir containing delvewheel-mangled
+ # msvcp140.dll
+ pyarrow_libs_dir = _os.path.join(
+ python_base_install, "Lib", "site-packages", "pyarrow.libs"
+ )
Review Comment:
what if we use the current folder and substitute `pyarrow` with
`pyarrow.libs`?
`_os.path.dirname(_os.path.abspath(__file__))` --> that's how we add it below
It feels slightly hardcoded and I am not sure if all environments
(virtualenv, system installed python, conda installed python) would replicate
this folder structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
