paleolimbot commented on code in PR #2609:
URL: https://github.com/apache/arrow-adbc/pull/2609#discussion_r1997917462
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -1123,7 +1174,27 @@ def fetch_record_batch(self) ->
pyarrow.RecordBatchReader:
# XXX(https://github.com/apache/arrow-adbc/issues/1523): return the
# "real" PyArrow reader since PyArrow may try to poke the internal C++
# reader pointer
- return self._results._reader._reader
+ return self._results.reader._reader
+
+ def fetch_pycapsule(self) -> _lib.ArrowArrayStreamHandle:
Review Comment:
A `GeoDataFrame` should probably just implement the PyCapsule protocol too
(but I think they were unsure about defaults for exactly what type to generate
at the time they added `to_arrow()` I think). I haven't spent that much time
with Python DBAPI to know what a cursor implies but implementing PyCapsule on
it seems right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
