lidavidm commented on code in PR #2609:
URL: https://github.com/apache/arrow-adbc/pull/2609#discussion_r1997784417
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -1123,7 +1174,27 @@ def fetch_record_batch(self) ->
pyarrow.RecordBatchReader:
# XXX(https://github.com/apache/arrow-adbc/issues/1523): return the
# "real" PyArrow reader since PyArrow may try to poke the internal C++
# reader pointer
- return self._results._reader._reader
+ return self._results.reader._reader
+
+ def fetch_pycapsule(self) -> _lib.ArrowArrayStreamHandle:
Review Comment:
Changed the docstring to clarify that it returns something implementing the
PyCapsule interface (which we want anyways since it's slightly more flexible
than directly returning the capsule object itself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
