sahib commented on PR #326: URL: https://github.com/apache/arrow-go/pull/326#issuecomment-2763234764
> @sahib can you address the linting and other CI issues here? I tried to fix the linting (I think you have to trigger the pipeline explicitly?). Interestingly, those were not broken due to my changes, but the template was wrong. I still have (at least one) [one failing test](https://github.com/sahib/arrow-go/blob/0dc5d50a8cf07caea8bb615d354b3020490e9c6a/arrow/array/numericbuilder.gen_test.go#L240) locally. I think this [fails rightfully so]( https://github.com/sahib/arrow-go/blob/77af38fa6cbbcf097117d180fe88406c3d20dd93/arrow/array/numericbuilder.gen.go#L221), since `strcvonv.ParseInt()` will not parse stuff like `Nan` or `+Inf`. Should it be `strconv.ParseFloat()` or should this just not work for Ints? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
