zeroshade commented on PR #326: URL: https://github.com/apache/arrow-go/pull/326#issuecomment-2779172254
Yup, I'll approve and merge this. > Most of the asm functions are selected over function variables during runtime (i.e. during init() different implementation are set based on cpu functions). Overall a nice approach, but it comes with a small performance penalty, as this prohibits inlining (and maybe some more things?). If I remember correctly, the Go compiler isn't able to inline assembly functions like this in the first place so we wouldn't be able to inline anyways. > I did push a dummy branch here: https://github.com/sahib/arrow-go/tree/bench/build-tag - seems like the whole platform selection gets less convoluted using this approach as well. All in all more minor stuff, but I wanted your opinion on this first. I like the idea, as long as the benchmarks in your branch support the idea and don't cause any performance regressions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
