Re: [PR] feat: add rounding logic and scale zero fix parse_decimal to match parse_string_to_decimal_native behavior [arrow-rs]

[via GitHub]

kazuyukitanimura commented on code in PR #7179:
URL: https://github.com/apache/arrow-rs/pull/7179#discussion_r2022138201


##########
arrow-cast/src/parse.rs:
##########
@@ -986,6 +1009,13 @@ pub fn parse_decimal<T: DecimalType>(
                 "parse decimal overflow ({s})"
             )));
         }
+        if scale == 0 {
+            result = result.div_wrapping(base.pow_wrapping(fractionals as u32))
+        }
+        //add one if >=5
+        if rounding_digit >= 5 {

Review Comment:
   Ah ok, makes sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org