AlenkaF commented on PR #45818: URL: https://github.com/apache/arrow/pull/45818#issuecomment-2769000039
Thanks, will have a look shortly! > I was unsure about how to approach "binary scalars implement perhaps the buffer protocol". You might want to have a look at: - the [buffer protocol implementation in PyArrow Buffer class](https://github.com/apache/arrow/blob/60b5ab9ee0bf070f03cf5c92fe0add0257543dfd/python/pyarrow/io.pxi#L1561-L1584), - and the Cython docs: - https://cython.readthedocs.io/en/latest/src/userguide/buffer.html - https://docs.python.org/3/c-api/buffer.html You can start with thinking about what to test. For testing use `memoryview` which exposes the buffer protocol, like in [this existing test](https://github.com/apache/arrow/blob/60b5ab9ee0bf070f03cf5c92fe0add0257543dfd/python/pyarrow/tests/test_tensor.py#L204-L226). > I was also unsure how to approach the code examples with min_max: The code example from the issue description is using **Python unpacking** which works for any iterator and that isn't implemented for a struct. See a good SO thread: https://stackoverflow.com/a/37837754. This will be solved when the struct scalar class will implement Sequence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
