sahib commented on code in PR #323:
URL: https://github.com/apache/arrow-go/pull/323#discussion_r2008014412
##########
arrow/ipc/reader.go:
##########
@@ -36,12 +36,15 @@ import (
// Reader expects a schema (plus any dictionaries) as the first messages
// in the stream, followed by records.
type Reader struct {
+ // refCount needs to be 64-bit aligned
+ // https://pkg.go.dev/sync/atomic#pkg-note-BUG
+ refCount int64
Review Comment:
I swapped with `atomic.Int64` now. I think this would need to be done on the
complete code base though. If I have some time next week I can offer to do
this. Along with that I could also double check that we don't have more
alignment issues I did not stumble into yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
