kylebarron commented on code in PR #7371:
URL: https://github.com/apache/arrow-rs/pull/7371#discussion_r2025866424
##########
parquet/src/arrow/async_reader/metadata.rs:
##########
@@ -82,7 +83,7 @@ pub trait MetadataSuffixFetch: MetadataFetch {
///
/// Note the returned type is a boxed future, often created by
/// [FutureExt::boxed]. See the trait documentation for an example
- fn fetch_suffix(&mut self, suffix: usize) -> BoxFuture<'_, Result<Bytes>>;
+ fn fetch_suffix(&mut self, suffix: u64) -> BoxFuture<'_, Result<Bytes>>;
Review Comment:
I don't have a strong opinion either way. I doubt we'll ever be making a
suffix request larger than u32 range, but it doesn't necessarily hurt for it to
be `u64` for parity with the other APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
