tustvold commented on PR #7371: URL: https://github.com/apache/arrow-rs/pull/7371#issuecomment-2784040032
I'm afraid I don't really have time to deep-dive on this, but I would emphasise what other have pointed out, that a blanket find & replace of usize with u64 is **NOT** what we should do. There is no point switching to u64 for quantities that are either already in memory, e.g. offsets into a ` Bytes`, or are assumed to fit - e.g. the metadata footer, a column chunk, etc... The actual impact should be limited to file offsets -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
