raulcd commented on code in PR #46057:
URL: https://github.com/apache/arrow/pull/46057#discussion_r2033388707
##########
python/pyarrow/acero.py:
##########
@@ -375,7 +396,13 @@ def _filter_table(table, expression):
])
result = decl.to_table(use_threads=True)
if is_batch:
- result = result.combine_chunks().to_batches()[0]
+ batches = result.combine_chunks().to_batches()
+ result = (
+ batches[0]
+ if batches
+ else _empty_record_batch_from_schema(result.schema)
Review Comment:
Do we really need the auxiliary function? Couldn't we just return result
(this is already an empty table)
##########
python/pyarrow/tests/arrow_44366.py:
##########
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This file is called from a test in test_pandas.py.
Review Comment:
This test is not called from pandas. The current tests with `arrow_xxx.py`
are specifically invoked. Could you add a test in `test_acero.py` instead of
creating this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
