eric-wang-1990 commented on code in PR #2692:
URL: https://github.com/apache/arrow-adbc/pull/2692#discussion_r2038561025
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -86,9 +100,70 @@ protected override TOpenSessionReq CreateSessionRequest()
Client_protocol_i64 =
(long)TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V7,
CanUseMultipleCatalogs = true,
};
+
+ // If not using queries to set server-side properties, include
them in Configuration
+ if (!_applySSPWithQueries)
+ {
+ req.Configuration = new Dictionary<string, string>();
+ var serverSideProperties = GetServerSideProperties();
+ foreach (var property in serverSideProperties)
+ {
+ req.Configuration[property.Key] = property.Value;
+ }
Review Comment:
I wonder what kind of logs we can add here. @davidhcoe Until the
logging/telemetry framework is ready do you recommend we log anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
