mbrobbel commented on code in PR #7412: URL: https://github.com/apache/arrow-rs/pull/7412#discussion_r2042096510
########## arrow-buffer/src/buffer/scalar.rs: ########## @@ -342,4 +345,19 @@ mod tests { assert_eq!(vec, input.as_slice()); assert_ne!(vec.as_ptr(), input.as_ptr()); } + + #[test] + fn scalar_buffer_impl_eq() { + fn are_equal<T: Eq>(a: &T, b: &T) -> bool { + a.eq(b) + } + + assert!( + are_equal( + &ScalarBuffer::<i16>::from(vec![23]), + &ScalarBuffer::<i16>::from(vec![23]) + ), + "ScalarBuffer should implement Eq if the inner typedoes" Review Comment: ```suggestion "ScalarBuffer should implement Eq if the inner type does" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org