raulcd commented on code in PR #46131:
URL: https://github.com/apache/arrow/pull/46131#discussion_r2044013830
##########
python/pyarrow/ipc.py:
##########
@@ -150,9 +140,8 @@ def _ensure_default_ipc_read_options(options):
return options or IpcReadOptions()
-def new_stream(sink, schema, *, use_legacy_format=None, options=None):
+def new_stream(sink, schema, *, options=None):
Review Comment:
This has been the name of the field for more than 5 years
(`use_legacy_format` and the documentation said it was deprecated). Maybe we do
not require to wait for a `DeprecationWarning` for a field that has been
documented as deprecated for 5 years and has the name `legacy` on it? This is
the commit that introduced the field (Arrow 1.0 already had it as legacy)
https://github.com/apache/arrow/commit/1a7519f42096f3342224adf7f1643ab11d5098b3
and it seems we can still use an environment variable to force using it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
