alamb commented on code in PR #334:
URL:
https://github.com/apache/arrow-rs-object-store/pull/334#discussion_r2045293398
##########
src/client/builder.rs:
##########
@@ -183,7 +183,8 @@ impl HttpRequestBuilder {
let mut error = None;
if let Ok(ref mut req) = self.request {
let mut out = format!("{}?", req.uri().path());
- let mut encoder = form_urlencoded::Serializer::new(&mut out);
+ let start_position = out.len();
Review Comment:
> [apache/arrow-rs#7183](https://github.com/apache/arrow-rs/pull/7183)
Changed the way the query string is serialized from:
>
> ```
> azurebase.com/path?comp=list&restype:container
> ```
>
> to:
>
> ```
> azurebase.com/path?&comp=list&restype:container # Note the leading & after
the ?
> ```
Does this change remove the `&` after `?`. I am having a hard time
reasoning about the change this behavior makes.
Is it possible to write some unit tests or something that can show the
before/after behavior (and prevent this code from being accidentally broken
again)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
