alamb commented on code in PR #334:
URL:
https://github.com/apache/arrow-rs-object-store/pull/334#discussion_r2045487830
##########
src/client/builder.rs:
##########
@@ -183,7 +183,8 @@ impl HttpRequestBuilder {
let mut error = None;
if let Ok(ref mut req) = self.request {
let mut out = format!("{}?", req.uri().path());
- let mut encoder = form_urlencoded::Serializer::new(&mut out);
+ let start_position = out.len();
Review Comment:
Maybe a unit test then (aka assert what URL is sent)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
