kou commented on code in PR #46095:
URL: https://github.com/apache/arrow/pull/46095#discussion_r2055174926
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -570,6 +570,17 @@ bool IsContainerNotFound(const Storage::StorageException&
e) {
return false;
}
+bool IsForbidden(const Storage::StorageException& e) {
+ // In some situations, only the ReasonPhrase is set and the
+ // ErrorCode is empty, so we check both.
+ if (e.ErrorCode == "AuthorizationFailure" ||
+ e.ReasonPhrase == "This request is not authorized to perform this
operation.") {
+ DCHECK_EQ(e.StatusCode, Http::HttpStatusCode::Forbidden);
+ return true;
+ }
+ return false;
Review Comment:
Can we use `return e.StatusCode == Http::HttpStatusCode::Forbidden` here?
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -1441,6 +1452,14 @@ Result<FileInfo> GetContainerPropsAsFileInfo(const
AzureLocation& location,
info.set_type(FileType::NotFound);
return info;
}
+
+ if (IsForbidden(exception)) {
+ // User delegated sas tokens don't allow for getting container
properties. Assume
+ // the container exists
+ info.set_type(FileType::Directory);
+ info.set_mtime(std::chrono::system_clock::now());
+ return info;
+ }
Review Comment:
What is happen when we access to nonexistent container? Is not forbidden
response is returned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
