emkornfield commented on a change in pull request #9862:
URL: https://github.com/apache/arrow/pull/9862#discussion_r606741388



##########
File path: go/arrow/internal/arrdata/ioutil.go
##########
@@ -172,6 +173,47 @@ func WriteFile(t *testing.T, f *os.File, mem 
memory.Allocator, schema *arrow.Sch
        }
 }
 
+// WriteFile writes a list of records to the given file descriptor, as an 
ARROW file.
+func WriteFileCompressed(t *testing.T, f *os.File, mem memory.Allocator, 
schema *arrow.Schema, recs []array.Record, codec flatbuf.CompressionType) {

Review comment:
       at least in other languages I'm familiar with there is some effort to 
hide the flat buffer details from consumers of the API.  Would it make sense to 
abstract that here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to