zeroshade commented on a change in pull request #9862:
URL: https://github.com/apache/arrow/pull/9862#discussion_r606820150
##########
File path: go/arrow/internal/arrdata/ioutil.go
##########
@@ -172,6 +173,47 @@ func WriteFile(t *testing.T, f *os.File, mem
memory.Allocator, schema *arrow.Sch
}
}
+// WriteFile writes a list of records to the given file descriptor, as an
ARROW file.
+func WriteFileCompressed(t *testing.T, f *os.File, mem memory.Allocator,
schema *arrow.Schema, recs []array.Record, codec flatbuf.CompressionType) {
Review comment:
So this is an internal package (note the "internal" in the path) which
means it cannot be imported or called outside of the `arrow` repo here. This is
only used for the unit tests so I figured it wasn't a problem to have it use
the enum from the flatbuffer details directly in this situation since it's not
an externally exposed API for consumers.
The only externally exposed API for consumers is the `WithLZ4` and
`WithZstd` functions that were added as options to be passed to the writer
which explicitly doesn't expose the flatbuffer details to external consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
