jorgecarleitao commented on pull request #9778:
URL: https://github.com/apache/arrow/pull/9778#issuecomment-813273983


   I am really sorry, this was sloppiness on my part: I should have checkout 
the code and go through it more carefully as FFI is always risky stuff. If you 
think it would take some pressure off, we can revert this PR until we find and 
fix this.
   
   Regardless, could you run the memory-check to see if we find the problem in 
our internal roundtrips? Something like
   
   ```
   cargo test --lib --feature memory-check -- --test-threads=1
   ```
   
   on the rust crate. This counts every alloc/realloc/dealloc over all buffers 
over all tests and [verifies that the sum is 
zero](https://github.com/apache/arrow/blob/master/rust/arrow/src/zz_memory_check.rs).
 The test-threads must be 1 so that tests run sequentially and the last test is 
the memory check.
   
   I would try to run this before this PR's commit just to make sure that 
things work as expected since we do not run this as part of our CI. If it 
passes, then I would try again after this PR's commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to