pitrou commented on a change in pull request #9778:
URL: https://github.com/apache/arrow/pull/9778#discussion_r606993862
##########
File path: rust/arrow/src/ffi.rs
##########
@@ -193,6 +216,42 @@ fn to_datatype(format: &str) -> Result<DataType> {
"ttm" => DataType::Time32(TimeUnit::Millisecond),
"ttu" => DataType::Time64(TimeUnit::Microsecond),
"ttn" => DataType::Time64(TimeUnit::Nanosecond),
+
+ // Note: The datatype null will only be created when called from
ArrowArray::buffer_len
+ // at that point the child data is not yet known, but it is also not
required to determine
+ // the buffer length of the list arrays.
+ "+l" => {
+ let nullable = schema.flags == 2;
Review comment:
Should be `(schema.flags & 2) != 0`. Also I'm surprised you're
sprinkling magic numbers in the code instead of defining a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
