adamreeve commented on code in PR #46283:
URL: https://github.com/apache/arrow/pull/46283#discussion_r2072720886
##########
cpp/src/parquet/encryption/two_level_cache_with_expiration.h:
##########
@@ -110,7 +110,7 @@ class TwoLevelCacheWithExpiration {
return cache_[access_token].cached_item();
}
- void CheckCacheForExpiredTokens(double cache_cleanup_period_seconds) {
+ void CheckCacheForExpiredTokens(double cache_cleanup_period_seconds = 0.0) {
Review Comment:
I think the 0.0 should be passed explicitly in the test rather than being a
default value. Having a default cleanup period of 0 seconds doesn't really make
sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
