criccomini commented on PR #348: URL: https://github.com/apache/arrow-rs-object-store/pull/348#issuecomment-2855511098
Couple of open questions: - How do y'all feel about the docs right now? They're just copied from DF. - WDYT about adding a `get_url` method that takes an object store and compares refs to find the URL for it in the registry. - I used `dashmap` since that's what DF was using. Not sure how you feel about adding the dependency. - One of the tests uses a clunk debug fmt thingy to verify the returned instance is of type LocalFileSystem. I couldn't figure out the right way to do this in rust. o4-mini-high failed me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
